Hi Boris, I love your patch! Yet something to improve:
[auto build test ERROR on kdave/for-next] [also build test ERROR on next-20210408] [cannot apply to v5.12-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Boris-Burkov/btrfs-support-fsverity/20210409-023606 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/dd118218fea47389631a62ec533207ba39e69b41 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Boris-Burkov/btrfs-support-fsverity/20210409-023606 git checkout dd118218fea47389631a62ec533207ba39e69b41 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): fs/btrfs/super.c: In function 'btrfs_fill_super': >> fs/btrfs/super.c:1368:6: error: 'struct super_block' has no member named >> 's_vop'; did you mean 's_op'? 1368 | sb->s_vop = &btrfs_verityops; | ^~~~~ | s_op vim +1368 fs/btrfs/super.c 1354 1355 static int btrfs_fill_super(struct super_block *sb, 1356 struct btrfs_fs_devices *fs_devices, 1357 void *data) 1358 { 1359 struct inode *inode; 1360 struct btrfs_fs_info *fs_info = btrfs_sb(sb); 1361 int err; 1362 1363 sb->s_maxbytes = MAX_LFS_FILESIZE; 1364 sb->s_magic = BTRFS_SUPER_MAGIC; 1365 sb->s_op = &btrfs_super_ops; 1366 sb->s_d_op = &btrfs_dentry_operations; 1367 sb->s_export_op = &btrfs_export_ops; > 1368 sb->s_vop = &btrfs_verityops; 1369 sb->s_xattr = btrfs_xattr_handlers; 1370 sb->s_time_gran = 1; 1371 #ifdef CONFIG_BTRFS_FS_POSIX_ACL 1372 sb->s_flags |= SB_POSIXACL; 1373 #endif 1374 sb->s_flags |= SB_I_VERSION; 1375 sb->s_iflags |= SB_I_CGROUPWB; 1376 1377 err = super_setup_bdi(sb); 1378 if (err) { 1379 btrfs_err(fs_info, "super_setup_bdi failed"); 1380 return err; 1381 } 1382 1383 err = open_ctree(sb, fs_devices, (char *)data); 1384 if (err) { 1385 btrfs_err(fs_info, "open_ctree failed"); 1386 return err; 1387 } 1388 1389 inode = btrfs_iget(sb, BTRFS_FIRST_FREE_OBJECTID, fs_info->fs_root); 1390 if (IS_ERR(inode)) { 1391 err = PTR_ERR(inode); 1392 goto fail_close; 1393 } 1394 1395 sb->s_root = d_make_root(inode); 1396 if (!sb->s_root) { 1397 err = -ENOMEM; 1398 goto fail_close; 1399 } 1400 1401 cleancache_init_fs(sb); 1402 sb->s_flags |= SB_ACTIVE; 1403 return 0; 1404 1405 fail_close: 1406 close_ctree(fs_info); 1407 return err; 1408 } 1409 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
