On Tue, Oct 10, 2023 at 04:40:18PM -0400, Josef Bacik wrote: > This adds the code necessary for per-extent encryption. We will store a > nonce for every extent we create, and then use the inode's policy and > the extents nonce to derive a per-extent key. > > This is meant to be flexible, if we choose to expand the on-disk extent > information in the future we have a version number we can use to change > what exists on disk. > > The file system indicates it wants to use per-extent encryption by > setting s_cop->set_extent_context. This also requires the use of inline > block encryption. > > The support is relatively straightforward, the only "extra" bit is we're > deriving a per-extent key to use for the encryption, the inode still > controls the policy and access to the master key. > > Signed-off-by: Josef Bacik <jo...@toxicpanda.com>
Planning to take a closer look at this patch, but one quick comment: could you explicitly document the choice to rely on blk-crypto? There are reasons for doing that, and it would be helpful to document them. - Eric
