Jeff Layton <[email protected]> wrote:

> +     /* full page write */
> +     if (offset == 0 && len >= thp_size(page))
> +             goto zero_out;

Why not just return?

David Howells <[email protected]> wrote:

> Why not:
> 
>       if (page_offset(page) >= i_size)

And if I switch to this, then:

        /* Zero-length file */
        if (i_size == 0)
                goto zero_out;

this is redundant.

David

--
Linux-cachefs mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-cachefs

Reply via email to