On 3/9/22 11:26 PM, Jeff Layton wrote: > On Tue, 2022-03-08 at 23:25 +0000, David Howells wrote: >> From: Jeffle Xu <jeffl...@linux.alibaba.com> >> >> Export fscache_end_operation() to avoid code duplication. >> >> Besides, considering the paired fscache_begin_read_operation() is >> already exported, it shall make sense to also export >> fscache_end_operation(). >> > > Not what I think of when you say "exporting" but the patch itself looks > fine. > Yes, maybe "fscache: make fscache_end_operation() generally available" as David said shall be better... -- Thanks, Jeffle -- Linux-cachefs mailing list Linux-cachefs@redhat.com https://listman.redhat.com/mailman/listinfo/linux-cachefs
- [Linux-cachefs] [PATCH v2 00/19] netfs: Prep for write helpe... David Howells
- [Linux-cachefs] [PATCH v2 01/19] fscache: export fscach... David Howells
- Re: [Linux-cachefs] [PATCH v2 01/19] fscache: expor... Jeff Layton
- Re: [Linux-cachefs] [PATCH v2 01/19] fscache: e... JeffleXu
- [Linux-cachefs] [PATCH v2 02/19] netfs: Generate enums ... David Howells
- Re: [Linux-cachefs] [PATCH v2 02/19] netfs: Generat... Jeff Layton
- Re: [Linux-cachefs] [PATCH v2 02/19] netfs: Generat... David Howells
- [Linux-cachefs] [PATCH v2 03/19] netfs: Rename netfs_re... David Howells
- [Linux-cachefs] [PATCH v2 04/19] netfs: Finish off rena... David Howells
- [Linux-cachefs] [PATCH v2 05/19] netfs: Split netfs_io_... David Howells