[Linux-cachefs] [PATCH v6 22/22] erofs: add 'tag' mount option

[Jeffle Xu]

Introduce 'tag' mount option to enable on-demand read sementics. In
this case, erofs could be mounted from blob files instead of blkdev.
By then users could specify the name of bootstrap blob file containing
the complete erofs image.

Signed-off-by: Jeffle Xu <jeffl...@linux.alibaba.com>
---
 fs/erofs/super.c | 44 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 38 insertions(+), 6 deletions(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 8ac400581784..6ea83f36842c 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -403,6 +403,7 @@ enum {
        Opt_dax,
        Opt_dax_enum,
        Opt_device,
+       Opt_tag,
        Opt_err
 };
 
@@ -427,6 +428,7 @@ static const struct fs_parameter_spec erofs_fs_parameters[] 
= {
        fsparam_flag("dax",             Opt_dax),
        fsparam_enum("dax",             Opt_dax_enum, erofs_dax_param_enums),
        fsparam_string("device",        Opt_device),
+       fsparam_string("tag",           Opt_tag),
        {}
 };
 
@@ -522,6 +524,16 @@ static int erofs_fc_parse_param(struct fs_context *fc,
                }
                ++ctx->devs->extra_devices;
                break;
+       case Opt_tag:
+#ifdef CONFIG_EROFS_FS_ONDEMAND
+               kfree(ctx->opt.tag);
+               ctx->opt.tag = kstrdup(param->string, GFP_KERNEL);
+               if (!ctx->opt.tag)
+                       return -ENOMEM;
+#else
+               errorfc(fc, "tag option not supported");
+#endif
+               break;
        default:
                return -ENOPARAM;
        }
@@ -596,9 +608,14 @@ static int erofs_fc_fill_super(struct super_block *sb, 
struct fs_context *fc)
 
        sb->s_magic = EROFS_SUPER_MAGIC;
 
-       if (!sb_set_blocksize(sb, EROFS_BLKSIZ)) {
-               erofs_err(sb, "failed to set erofs blksize");
-               return -EINVAL;
+       if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && erofs_is_nodev_mode(sb)) {
+               sb->s_blocksize = EROFS_BLKSIZ;
+               sb->s_blocksize_bits = LOG_BLOCK_SIZE;
+       } else {
+               if (!sb_set_blocksize(sb, EROFS_BLKSIZ)) {
+                       erofs_err(sb, "failed to set erofs blksize");
+                       return -EINVAL;
+               }
        }
 
        sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
@@ -607,7 +624,6 @@ static int erofs_fc_fill_super(struct super_block *sb, 
struct fs_context *fc)
 
        sb->s_fs_info = sbi;
        sbi->opt = ctx->opt;
-       sbi->dax_dev = fs_dax_get_by_bdev(sb->s_bdev, &sbi->dax_part_off);
        sbi->devs = ctx->devs;
        ctx->devs = NULL;
 
@@ -623,6 +639,10 @@ static int erofs_fc_fill_super(struct super_block *sb, 
struct fs_context *fc)
                err = super_setup_bdi(sb);
                if (err)
                        return err;
+
+               sbi->dax_dev = NULL;
+       } else {
+               sbi->dax_dev = fs_dax_get_by_bdev(sb->s_bdev, 
&sbi->dax_part_off);
        }
 
        err = erofs_read_superblock(sb);
@@ -685,6 +705,11 @@ static int erofs_fc_fill_super(struct super_block *sb, 
struct fs_context *fc)
 
 static int erofs_fc_get_tree(struct fs_context *fc)
 {
+       struct erofs_fs_context *ctx = fc->fs_private;
+
+       if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && ctx->opt.tag)
+               return get_tree_nodev(fc, erofs_fc_fill_super);
+
        return get_tree_bdev(fc, erofs_fc_fill_super);
 }
 
@@ -734,6 +759,7 @@ static void erofs_fc_free(struct fs_context *fc)
        struct erofs_fs_context *ctx = fc->fs_private;
 
        erofs_free_dev_context(ctx->devs);
+       kfree(ctx->opt.tag);
        kfree(ctx);
 }
 
@@ -774,7 +800,10 @@ static void erofs_kill_sb(struct super_block *sb)
 
        WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);
 
-       kill_block_super(sb);
+       if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && erofs_is_nodev_mode(sb))
+               generic_shutdown_super(sb);
+       else
+               kill_block_super(sb);
 
        sbi = EROFS_SB(sb);
        if (!sbi)
@@ -896,7 +925,10 @@ static int erofs_statfs(struct dentry *dentry, struct 
kstatfs *buf)
 {
        struct super_block *sb = dentry->d_sb;
        struct erofs_sb_info *sbi = EROFS_SB(sb);
-       u64 id = huge_encode_dev(sb->s_bdev->bd_dev);
+       u64 id = 0;
+
+       if (!IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) || !erofs_is_nodev_mode(sb))
+               id = huge_encode_dev(sb->s_bdev->bd_dev);
 
        buf->f_type = sb->s_magic;
        buf->f_bsize = EROFS_BLKSIZ;
-- 
2.27.0

--
Linux-cachefs mailing list
Linux-cachefs@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-cachefs