Re: [Linux-cachefs] [PATCH v3] cachefiles: fix error return code in cachefiles_ondemand_copen()

[David Howells]

        /* fail OPEN request if copen format is invalid */
        ret = kstrtol(psize, 0, &size);
        if (ret) {
                req->error = ret;
                goto out;
        }

        /* fail OPEN request if daemon reports an error */
        if (size < 0) {
                if (!IS_ERR_VALUE(size))
                        ret = size = -EINVAL;
                req->error = size;
                goto out;
        }

Should ret get set to the error in size?

David
--
Linux-cachefs mailing list
Linux-cachefs@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-cachefs