On Sun, 27 Mar 2011 23:13:45 +0400
Pavel Shilovsky <[email protected]> wrote:
> > int cifs_file_strict_mmap(struct file *file, struct vm_area_struct *vma)
> > {
> > int rc, xid;
> > @@ -1920,6 +1918,7 @@ int cifs_file_strict_mmap(struct file *file, struct
> > vm_area_struct *vma)
> > cifs_invalidate_mapping(inode);
> >
> > rc = generic_file_mmap(file, vma);
> > + vma->vm_ops = &cifs_file_vm_ops;
>
> May be we should set this only if generic_file_mmap succeed and rc == 0?
>
I don't think it really matters but you're probably right that it won't
hurt to do so. All of the existing callers of generic_file_mmap that
set the vm_ops don't do it unless generic_file_mmap succeeds. I'll
respin it...
--
Jeff Layton <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
