On Mon, 30 Apr 2012 17:36:21 +0300 Dan Carpenter <[email protected]> wrote:
> This test is always true so it means we revalidate the length every > time, which generates more network traffic. When it is SEEK_SET or > SEEK_CUR, then we don't need to revalidate. > > Signed-off-by: Dan Carpenter <[email protected]> > --- > v2: I had the test reversed in the first version. > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index 811245b..4a6ad20 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -699,7 +699,7 @@ static loff_t cifs_llseek(struct file *file, loff_t > offset, int origin) > * origin == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate > * the cached file length > */ > - if (origin != SEEK_SET || origin != SEEK_CUR) { > + if (origin != SEEK_SET && origin != SEEK_CUR) { > int rc; > struct inode *inode = file->f_path.dentry->d_inode; > Looks good. Reviewed-by: Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
