On Fri, 13 Jul 2012 17:12:51 +0400
Pavel Shilovsky <[email protected]> wrote:

> 2012/7/13 Pavel Shilovsky <[email protected]>:
> > Hi there!
> >
> > I faced with an interesting problem:
> > Windows 7 send lease break just after granted lease on open - so, we
> > don't have time to populate cifsFileInfo structure and can't determine
> > oplock break because we simply don't find appropriate fid. I think
> > this problem can be happen for CIFS/SMB2.0 too (e.g. if another client
> > opens the file just after us).
> >
> > So, what do you think about creating delegating the oplock break
> > processing to workqueue and return to demultiplex thread immideately?
> > It give us a small timeout itself and we can set another defined
> > timeout explicitly.
> >
> > --
> > Best regards,
> > Pavel Shilovsky.
> 
> I created a patch that fixes the problem for lease breaks - we can do
> smth similiar for oplock breaks too:
> 
> http://git.altlinux.org/people/piastry/public/?p=cifs-2.6.git;a=commit;h=b918551247997057f4467dfc332d47c547449ddd
> 

What guarantee is there that this fid will be on the list by the time
the work runs? It seems to me that this just narrows the race window a
bit without fully closing it.

-- 
Jeff Layton <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to