On Fri, 2013-07-05 at 18:40 +0200, David Disseldorp wrote: > On Thu, 4 Jul 2013 14:43:23 -0500 > Steve French <[email protected]> wrote: > > > I merged an equivalent but slightly smaller version of your patch into > > cifs-2.6.git (see below) and added stable since we should not be > > returning nlink of 0. Let me know if any objections. > > Looks good to me Steve. > FWIW, I've been using the following patch to replicate the > NumberOfLinks=0 behaviour on Samba: > http://gitweb.samba.org/?p=ddiss/samba.git;a=commitdiff;h=93c8795c9a9e9f > > Cheers, David > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html
I'm sorry, this patch is incomplete. It ignores the readdir codepath completely. If Steve has already merged this, then it needs a follow-on patch that fixes the readdir code too, probably with the same workaround in cifs_fill_common_info. Otherwise, you're going to end up with different st_nlink values depending on whether it got instantated by a readdir() or stat(). -- Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
