Herbert Xu wrote:
> On Mon, May 22, 2006 at 02:20:18PM +1200, Michal Ludvig wrote:
>> Add missing accessors for new crypto_alg fields.
> 
> Who's going to use these accessors?

Me ;-)

Well, not personally, but padlock-sha will.

BTW in padlock fallback path I need to make scatterlist from const char*
buffer. However the macros in scatterlist.h take non-const void*.
Should I
1) make them const (works for me and I'm not getting any compilation
warnings from other modules).
2) make my local copy of sg_set_buf() with const void parameter
3) let gcc keep complaining

Following is a patch that does #1.

Index: linux/include/linux/scatterlist.h
===================================================================
--- linux.orig/include/linux/scatterlist.h
+++ linux/include/linux/scatterlist.h
@@ -5,7 +5,7 @@
 #include <linux/mm.h>
 #include <linux/string.h>

-static inline void sg_set_buf(struct scatterlist *sg, void *buf,
+static inline void sg_set_buf(struct scatterlist *sg, const void *buf,
                              unsigned int buflen)
 {
        sg->page = virt_to_page(buf);
@@ -13,7 +13,7 @@ static inline void sg_set_buf(struct sca
        sg->length = buflen;
 }

-static inline void sg_init_one(struct scatterlist *sg, void *buf,
+static inline void sg_init_one(struct scatterlist *sg, const void *buf,
                               unsigned int buflen)
 {
        memset(sg, 0, sizeof(*sg));
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to