Sebastian Siewior <[EMAIL PROTECTED]> wrote: > > Currently the crypto driver has to allocate a structure in order to > remember later whether encrypt or decrypt is requested. > Isn't it better to add a operation field into the request struct which > contains the requested operation (set but the crypto user)? This would > then replace encrypt & decrypt function with a crypt function which > queues the request.
No doubt that you have to allocate it one way or another. Not allocating it explicitly means that you have the freedom of representing it in the most convenient fashion. For example, the cryptd module represents it using a function pointer. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
