* Herbert Xu | 2007-06-22 20:41:30 [+0800]:

>On Thu, Jun 14, 2007 at 12:29:00PM +0000, Sebastian Siewior wrote:
>> 
>> Maybe my computer is just as tired as I am. In general I thing 64bit
>> registers should be prefered.
>> 
>> Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
>
>OK this makes sense.  However you need to make sure that alignmask
>is set appropriately (i.e., at least 8/16).

I don't thing I understand. Why do I have to change the alignmask for
the xor operation? I guess you are talking about crypto_cbc_alloc()

|if (!(alg->cra_blocksize % 4))
|        inst->alg.cra_alignmask |= 3;

don't you?
Since this (also) changes the alignment of in+out data I would prefer not
to. The speed up you gain from less xors is probably less than what you
spent on additional kmap()/memcpy()/kmalloc() in case the data is %4 but
not %5.

>Cheers,
Sebastian
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to