On Thu, Oct 25, 2007 at 12:48:29PM +0100, Denys Vlasenko wrote: > On Thursday 25 October 2007 12:43, Denys Vlasenko wrote: > > Hi Hervert, > > > > Please review and maybe propagate upstream following patches. > > > > camellia5.diff > > Use alternative key setup implementation with mostly 64-bit ops > > if BITS_PER_LONG >= 64. Both much smaller and much faster. > > > > Unify camellia_en/decrypt128/256 into camellia_do_en/decrypt. > > Code was similar, with just one additional if() we can use came code. > > > > If CONFIG_CC_OPTIMIZE_FOR_SIZE is defined, > > use loop in camellia_do_en/decrypt instead of unrolled code. > > ~5% encrypt/decrypt slowdown.
Having two versions of the cdoe is unmaintainable. So please either decide that 5% is worth it or isn't. The rest of this patch looks fine. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
