On Wed, Jul 15, 2009 at 03:16:05PM +0800, Herbert Xu wrote: > crypto: padlock - Switch sha to shash > > This patch converts the padlock-sha implementation to shash. > In doing so the existing mechanism of storing the data until > final is no longer viable as we do not have a way of allocating > data in crypto_shash_init and then reliably freeing it. > > This is just as well because a better way of handling the problem > is to hash everything but the last chunk using normal sha code > and then provide the intermediate result to the padlock device. > > This is good enough because the primary application of padlock-sha > is IPsec and there the data is laid out in the form of an hmac > header followed by the rest of the packet. In essence we can > provide all the data to the padlock as the hmac header only needs > to be hashed once. > > Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> > --- > > drivers/crypto/Kconfig | 2 > drivers/crypto/padlock-sha.c | 333 > ++++++++++++++++++++----------------------- > 2 files changed, 156 insertions(+), 179 deletions(-) >
Just FYI, I'm getting the following compiler error: CC [M] drivers/crypto/padlock-sha.o LD kernel/built-in.o /home/klassert/git/linux-sinafe-2.6/drivers/crypto/padlock-sha.c: In function 'padlock_sha256_finup': /home/klassert/git/linux-sinafe-2.6/drivers/crypto/padlock-sha.c:166: error: impossible register constraint in 'asm' /home/klassert/git/linux-sinafe-2.6/drivers/crypto/padlock-sha.c:166: error: impossible register constraint in 'asm' /home/klassert/git/linux-sinafe-2.6/drivers/crypto/padlock-sha.c:176: confused by earlier errors, bailing out make[3]: *** [drivers/crypto/padlock-sha.o] Error 1 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
