>> +    /* assign new context to device */
>> +    ctx->dd = dd;
>> +    dd->ctx = ctx;
>> +
>> +    if (ctx->flags & FLAGS_NEW_KEY) {
>> +            /* copy the key */
>> +            memset(dd->ivkey_base, 0, AES_HW_KEY_TABLE_LENGTH_BYTES);
>> +            memcpy(dd->ivkey_base, ctx->key, ctx->keylen);
> these really should be writes to mutually exclusive addresses.

Why?

>> +    /* copy the key to the key slot */
>> +    memset(dd->ivkey_base, 0, AES_HW_KEY_TABLE_LENGTH_BYTES);
>> +    memcpy(dd->ivkey_base, seed + DEFAULT_RNG_BLK_SZ, AES_KEYSIZE_128);
> should be to mutually exclusive addresses

Why?
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to