[PATCH 1/4] crypto: picoxcell - Use devm_ioremap_resource()

[Jingoo Han]

>From c0c9c31eba90635cac93f3d5e5311beb10afafb7 Mon Sep 17 00:00:00 2001
From: Jingoo Han <jg1....@samsung.com>
Date: Wed, 12 Feb 2014 13:08:54 +0900
Subject: [PATCH 1/4] crypto: picoxcell - Use devm_ioremap_resource()

Use devm_ioremap_resource() in order to make the code simpler,
and remove redundant return value check of platform_get_resource()
because the value is checked by devm_ioremap_resource().

Signed-off-by: Jingoo Han <jg1....@samsung.com>
---
 drivers/crypto/picoxcell_crypto.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/crypto/picoxcell_crypto.c 
b/drivers/crypto/picoxcell_crypto.c
index a6175ba..5da5b98 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -1720,22 +1720,16 @@ static int spacc_probe(struct platform_device *pdev)
        engine->name = dev_name(&pdev->dev);
 
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       engine->regs = devm_ioremap_resource(&pdev->dev, mem);
+       if (IS_ERR(engine->regs))
+               return PTR_ERR(engine->regs);
+
        irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!mem || !irq) {
+       if (!irq) {
                dev_err(&pdev->dev, "no memory/irq resource for engine\n");
                return -ENXIO;
        }
 
-       if (!devm_request_mem_region(&pdev->dev, mem->start, resource_size(mem),
-                                    engine->name))
-               return -ENOMEM;
-
-       engine->regs = devm_ioremap(&pdev->dev, mem->start, resource_size(mem));
-       if (!engine->regs) {
-               dev_err(&pdev->dev, "memory map failed\n");
-               return -ENOMEM;
-       }
-
        if (devm_request_irq(&pdev->dev, irq->start, spacc_spacc_irq, 0,
                             engine->name, engine)) {
                dev_err(engine->dev, "failed to request IRQ\n");
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html