Re: [PATCH 16/26] libceph: Use skcipher

[Herbert Xu]

On Mon, Jan 25, 2016 at 05:18:47PM +0100, Ilya Dryomov wrote:
> 
> Could you get rid of ivsize instead of assigning to it - see the
> attached diff?

How about an incremental patch like this? Thanks!

---8<---
From: Ilya Dryomov <idryo...@gmail.com>
Subject: libceph: Remove unnecessary ivsize variables

This patch removes the unnecessary ivsize variabls as they always
have the value of AES_BLOCK_SIZE.

Signed-off-by: Ilya Dryomov <idryo...@gmail.com>

diff --git a/net/ceph/crypto.c b/net/ceph/crypto.c
index fb9cb2b..db2847a 100644
--- a/net/ceph/crypto.c
+++ b/net/ceph/crypto.c
@@ -166,8 +166,7 @@ static int ceph_aes_encrypt(const void *key, int key_len,
        struct crypto_skcipher *tfm = ceph_crypto_alloc_cipher();
        SKCIPHER_REQUEST_ON_STACK(req, tfm);
        int ret;
-       int ivsize = AES_BLOCK_SIZE;
-       char iv[ivsize];
+       char iv[AES_BLOCK_SIZE];
        size_t zero_padding = (0x10 - (src_len & 0x0f));
        char pad[16];
 
@@ -186,7 +185,7 @@ static int ceph_aes_encrypt(const void *key, int key_len,
                goto out_tfm;
 
        crypto_skcipher_setkey((void *)tfm, key, key_len);
-       memcpy(iv, aes_iv, ivsize);
+       memcpy(iv, aes_iv, AES_BLOCK_SIZE);
 
        skcipher_request_set_tfm(req, tfm);
        skcipher_request_set_callback(req, 0, NULL, NULL);
@@ -229,8 +228,7 @@ static int ceph_aes_encrypt2(const void *key, int key_len, 
void *dst,
        struct crypto_skcipher *tfm = ceph_crypto_alloc_cipher();
        SKCIPHER_REQUEST_ON_STACK(req, tfm);
        int ret;
-       int ivsize = AES_BLOCK_SIZE;
-       char iv[ivsize];
+       char iv[AES_BLOCK_SIZE];
        size_t zero_padding = (0x10 - ((src1_len + src2_len) & 0x0f));
        char pad[16];
 
@@ -250,7 +248,7 @@ static int ceph_aes_encrypt2(const void *key, int key_len, 
void *dst,
                goto out_tfm;
 
        crypto_skcipher_setkey((void *)tfm, key, key_len);
-       memcpy(iv, aes_iv, ivsize);
+       memcpy(iv, aes_iv, AES_BLOCK_SIZE);
 
        skcipher_request_set_tfm(req, tfm);
        skcipher_request_set_callback(req, 0, NULL, NULL);
@@ -294,8 +292,7 @@ static int ceph_aes_decrypt(const void *key, int key_len,
        struct crypto_skcipher *tfm = ceph_crypto_alloc_cipher();
        SKCIPHER_REQUEST_ON_STACK(req, tfm);
        char pad[16];
-       int ivsize = AES_BLOCK_SIZE;
-       char iv[16];
+       char iv[AES_BLOCK_SIZE];
        int ret;
        int last_byte;
 
@@ -310,7 +307,7 @@ static int ceph_aes_decrypt(const void *key, int key_len,
                goto out_tfm;
 
        crypto_skcipher_setkey((void *)tfm, key, key_len);
-       memcpy(iv, aes_iv, ivsize);
+       memcpy(iv, aes_iv, AES_BLOCK_SIZE);
 
        skcipher_request_set_tfm(req, tfm);
        skcipher_request_set_callback(req, 0, NULL, NULL);
@@ -363,8 +360,7 @@ static int ceph_aes_decrypt2(const void *key, int key_len,
        struct crypto_skcipher *tfm = ceph_crypto_alloc_cipher();
        SKCIPHER_REQUEST_ON_STACK(req, tfm);
        char pad[16];
-       int ivsize = AES_BLOCK_SIZE;
-       char iv[ivsize];
+       char iv[AES_BLOCK_SIZE];
        int ret;
        int last_byte;
 
@@ -380,7 +376,7 @@ static int ceph_aes_decrypt2(const void *key, int key_len,
                goto out_tfm;
 
        crypto_skcipher_setkey((void *)tfm, key, key_len);
-       memcpy(iv, aes_iv, ivsize);
+       memcpy(iv, aes_iv, AES_BLOCK_SIZE);
 
        skcipher_request_set_tfm(req, tfm);
        skcipher_request_set_callback(req, 0, NULL, NULL);

-- 
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html