[patch 1/2] crypto: mxc-scc - signedness bugs in mxc_scc_ablkcipher_req_init()

[Dan Carpenter]

->src_nents and ->dst_nents are unsigned so they can't be less than
zero.  I fixed this by introducing a temporary "nents" variable.

Fixes: d293b640ebd5 ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/crypto/mxc-scc.c b/drivers/crypto/mxc-scc.c
index 38b01bf..9b348a7 100644
--- a/drivers/crypto/mxc-scc.c
+++ b/drivers/crypto/mxc-scc.c
@@ -210,18 +210,21 @@ static int mxc_scc_ablkcipher_req_init(struct 
ablkcipher_request *req,
                                       struct mxc_scc_ctx *ctx)
 {
        struct mxc_scc *scc = ctx->scc;
+       int nents;
 
-       ctx->src_nents = sg_nents_for_len(req->src, req->nbytes);
-       if (ctx->src_nents < 0) {
+       nents = sg_nents_for_len(req->src, req->nbytes);
+       if (nents < 0) {
                dev_err(scc->dev, "Invalid number of src SC");
-               return ctx->src_nents;
+               return nents;
        }
+       ctx->src_nents = nents;
 
-       ctx->dst_nents = sg_nents_for_len(req->dst, req->nbytes);
-       if (ctx->dst_nents < 0) {
+       nents = sg_nents_for_len(req->dst, req->nbytes);
+       if (nents < 0) {
                dev_err(scc->dev, "Invalid number of dst SC");
-               return ctx->dst_nents;
+               return nents;
        }
+       ctx->dst_nents = nents;
 
        ctx->size = 0;
        ctx->offset = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html