On Mon, Aug 29, 2016 at 12:19:53PM +0100, Ard Biesheuvel wrote:
> Since commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero"),
> all ahash drivers are required to implement import()/export(), and must have
> a non-zero statesize. Fix this for the ARM Crypto Extensions GHASH
> implementation.
>
> Fixes: 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero")
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
> arch/arm/crypto/ghash-ce-glue.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/crypto/ghash-ce-glue.c b/arch/arm/crypto/ghash-ce-glue.c
> index 1568cb5cd870..212aaa715fdb 100644
> --- a/arch/arm/crypto/ghash-ce-glue.c
> +++ b/arch/arm/crypto/ghash-ce-glue.c
> @@ -220,6 +220,29 @@ static int ghash_async_digest(struct ahash_request *req)
> }
> }
>
> +static int ghash_async_import(struct ahash_request *req, const void *in)
> +{
> + struct ahash_request *cryptd_req = ahash_request_ctx(req);
> + struct shash_desc *desc = cryptd_shash_desc(cryptd_req);
> + struct ghash_desc_ctx *dctx = shash_desc_ctx(desc);
> +
> + ghash_async_init(req);
Is this really needed?
> + *dctx = *(const struct ghash_desc_ctx *)in;
I'd prefer to call the underlying shash import/export functions
like we do in cryptd.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
