> Use devm_hwrng_register instead of hwrng_register. It avoids the need > to handle unregistration explicitly from the remove function. > > Signed-off-by: Romain Perier <romain.per...@free-electrons.com> > --- > drivers/char/hw_random/omap-rng.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/char/hw_random/omap-rng.c > b/drivers/char/hw_random/omap-rng.c > index d47b24d..171c3e8 100644 > --- a/drivers/char/hw_random/omap-rng.c > +++ b/drivers/char/hw_random/omap-rng.c > @@ -381,7 +381,7 @@ static int omap_rng_probe(struct platform_device *pdev) > if (ret) > goto err_ioremap; > > - ret = hwrng_register(&omap_rng_ops); > + ret = devm_hwrng_register(dev, &omap_rng_ops); > if (ret) > goto err_register; > > @@ -402,8 +402,6 @@ static int omap_rng_remove(struct platform_device *pdev) > { > struct omap_rng_dev *priv = platform_get_drvdata(pdev); > > - hwrng_unregister(&omap_rng_ops); > - > priv->pdata->cleanup(priv); > > pm_runtime_put_sync(&pdev->dev); > --
If devm_hwrng_register is used hwrng_unregister will be called after pm_runtime_disable is called. If RNG device is in use calling omap_rng_remove may not work properly. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html