On Wed, Nov 16, 2016 at 04:57:42PM +0800, Herbert Xu wrote: > On Tue, Nov 15, 2016 at 08:06:47PM +0100, Stephan Mueller wrote: > > > > Shall the fix be rolled into the patch together with the fix for the tag > > value > > as well as the crash fix? Or can we have a stand-alone patch fixing this. > > I think these are two separate issues and we don't need to fix them > all in one go. > > > Btw., how do you suggest that should be fixed? I would assume that this > > needs > > to be fixed on a per-implementation basis. I tested authenc and it copies > > the > > buffers over. gcm_base(ctr-aes-aesni,ghash-clmulni), rfc4106-gcm-aesni or > > ccm_base(ctr-aes-aesni,aes-aesni) do not copy the AD over. > > We should fix as much as we can and then add a testmgr test to find > the rest.
Alternatively we can add the copying code to algif_aead when src != dst. I think that's probably the easier fix. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
