On 01/03/18 22:50, Krzysztof Kozlowski wrote:
ahash_request 'req' argument passed by the caller
omap_sham_handle_queue() cannot be NULL here because it is obtained from
non-NULL pointer via container_of().

This fixes smatch warning:
     drivers/crypto/omap-sham.c:812 omap_sham_prepare_request() warn: variable 
dereferenced before check 'req' (see line 805)

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>

Acked-by: Tero Kristo <t-kri...@ti.com>

---
  drivers/crypto/omap-sham.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 86b89ace836f..7650b1b449bb 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -809,9 +809,6 @@ static int omap_sham_prepare_request(struct ahash_request 
*req, bool update)
        bool final = rctx->flags & BIT(FLAGS_FINUP);
        int xmit_len, hash_later;
- if (!req)
-               return 0;
-
        bs = get_block_size(rctx);
if (update)


--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Reply via email to