On 7/23/2019 4:20 AM, Vakul Garg wrote:
>>> @@ -64,6 +65,7 @@ struct dpaa2_caam_priv {
>>> struct iommu_domain *domain;
>>>
>>> struct dpaa2_caam_priv_per_cpu __percpu *ppriv;
>>> + struct dentry *dfs_root;
>> dfs_root is used only in dpseci-debugfs.c, let's have it there as global.
>>
>
> I submitted this change in v3. There is still a minor issue with this patch
> version.
> Before submitting the next v4, I have a question.
>
> Could there be a situation that there are multiple dpseci objects assigned
> to kernel?
In theory, yes.
fsl-mc, the bus dpseci devices sit on, allows for multiple instances.
However, caam/qi2 (driver for dpseci devices) doesn't have support
for this.
For e.g., all dpseci instances would try to register the algorithms using
the same name & driver name - something that will trigger an error
in crypto API.
This could be easily fixed, however the real issue is that
there is no load balancing support - neither at crypto API level
nor at driver level.
> In that case, we need to maintain dfs_root for each separately.
>
Ok, let's keep dfs_root per device.
For now this has no practical value, but at least makes the work easier
in case load balancing support is added at some point.
Horia
