Re: [PATCH v3 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine

[Maxime Ripard]

On Thu, Oct 10, 2019 at 08:23:19PM +0200, Corentin Labbe wrote:
> +     ce->reset = devm_reset_control_get_optional(&pdev->dev, "bus");
> +     if (IS_ERR(ce->reset)) {
> +             if (PTR_ERR(ce->reset) == -EPROBE_DEFER)
> +                     return PTR_ERR(ce->reset);
> +             dev_err(&pdev->dev, "No reset control found\n");
> +             return PTR_ERR(ce->reset);
> +     }

There's only one reset so you don't need that name.

And I'm not sure why you're using the optional variant, it's required
by your binding.

Maxime

signature.asc
Description: PGP signature