On Fri, May 15, 2020 at 10:50 PM Richard Weinberger <[email protected]> wrote: > > ----- Ursprüngliche Mail ----- > > Von: "Eric Biggers" <[email protected]> > > An: "Sascha Hauer" <[email protected]>, "richard" <[email protected]> > > CC: "linux-mtd" <[email protected]>, "Linux Crypto Mailing > > List" <[email protected]>, "stable" > > <[email protected]> > > Gesendet: Freitag, 15. Mai 2020 21:17:04 > > Betreff: Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize() > > > On Mon, May 04, 2020 at 09:16:44AM +0200, Sascha Hauer wrote: > >> On Fri, May 01, 2020 at 10:59:45PM -0700, Eric Biggers wrote: > >> > From: Eric Biggers <[email protected]> > >> > > >> > crypto_shash_descsize() returns the size of the shash_desc context > >> > needed to compute the hash, not the size of the hash itself. > >> > > >> > crypto_shash_digestsize() would be correct, or alternatively using > >> > c->hash_len and c->hmac_desc_len which already store the correct values. > >> > But actually it's simpler to just use stack arrays, so do that instead. > >> > > >> > Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication > >> > support") > >> > Fixes: da8ef65f9573 ("ubifs: Authenticate replayed journal") > >> > Cc: <[email protected]> # v4.20+ > >> > Cc: Sascha Hauer <[email protected]> > >> > Signed-off-by: Eric Biggers <[email protected]> > >> > >> Looks better that way, thanks. > >> > >> Acked-by: Sascha Hauer <[email protected]> > >> > > > > Richard, could you take this through the ubifs tree for 5.8? > > Sure. I actually will send a PR with various MTD related fixes > for 5.7.
Applied. Thanks for fixing! -- Thanks, //richard
