On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote: > On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you > > > have 2 tabs for your 'struct attribute' variables, which is really odd. > [] > > Also, many of the attribute callbacks in that file seem to all have > > their leading '{' in the wrong place. Odd that checkpatch.pl doesn't > > catch that... > > checkpatch doesn't really check much about inconsistent > indentation. I believe the only new statement indentation > check is after an if. > > For instance, checkpatch doesn't emit a warning on this code: > > struct foo { > int bar; > }; > > struct foo *alloc_foo(void) > { > struct foo *baz = malloc(sizeof(struct foo)); > if (baz) > baz->bar = 1; > return baz; > }
Ok, but the following code in that file should be caught, right: static ssize_t partition_handle_show(struct device *dev, struct device_attribute *attr, char *buf) { struct visor_device *vdev = to_visor_device(dev); u64 handle = visorchannel_get_clientpartition(vdev->visorchannel); return sprintf(buf, "0x%llx\n", handle); } static DEVICE_ATTR_RO(partition_handle); The initial { is in the wrong place... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html