Hi,
On Feb 22 2018 11:01, Randy Dunlap wrote:
On 02/21/2018 05:57 PM, Takashi Sakamoto wrote:
Hi,
Furthermore, 'scripts/checkpatch.pl' generates three warnings.
```
$ ./scripts/checkpatch.pl /tmp/patches/*
...
----------------------------------------------------------------------------
/tmp/patches/0004-documentation-firewire-add-basic-firewire.rst-to-dri.patch
----------------------------------------------------------------------------
WARNING: Use a single space after Cc:
#11:
Cc: Stefan Richter <stef...@s5r6.in-berlin.de>
WARNING: Use a single space after Cc:
#12:
Cc: linux1394-de...@lists.sourceforge.net
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 3 warnings, 40 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/tmp/patches/0004-documentation-firewire-add-basic-firewire.rst-to-dri.patch
has style problems, please review.
```
One of them can be ignored (adding a new file by a developer who is not in
MAINTAINERS)
On Feb 22 2018 10:07, Randy Dunlap wrote:
From: Randy Dunlap <rdun...@infradead.org>
Add a basic Firewire/IEEE 1394 driver API chapter to the Linux
kernel documentation.
Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: Stefan Richter <stef...@s5r6.in-berlin.de>
Cc: linux1394-de...@lists.sourceforge.net
However, the rest can be improved. I have never seen any case with multiple
spaces between any tag and name. It's better to modify them to follow
undocumented convention in Linux kernel development.
It's a tab, but I'll fix it.
Aha, I overlooked it.
Anyway, in next time, please send a cover letter together to aggregate
each of your patch. It helps me to ask maintainers to add one
'Reviewed-by' tag from me.
Thanks
Takashi Sakamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
