From: Ravi Bangoria <ravi.bango...@linux.ibm.com>

map_info is very generic name, rename it to uprobe_map_info.
Renaming will help to export this structure outside of the
file.

Also rename free_map_info() to uprobe_free_map_info() and
build_map_info() to uprobe_build_map_info().

Signed-off-by: Ravi Bangoria <ravi.bango...@linux.ibm.com>
Reviewed-by: Jérôme Glisse <jgli...@redhat.com>
---
 kernel/events/uprobes.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 1d439c7..477dc42 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -695,28 +695,30 @@ static void delete_uprobe(struct uprobe *uprobe)
        put_uprobe(uprobe);
 }
 
-struct map_info {
-       struct map_info *next;
+struct uprobe_map_info {
+       struct uprobe_map_info *next;
        struct mm_struct *mm;
        unsigned long vaddr;
 };
 
-static inline struct map_info *free_map_info(struct map_info *info)
+static inline struct uprobe_map_info *
+uprobe_free_map_info(struct uprobe_map_info *info)
 {
-       struct map_info *next = info->next;
+       struct uprobe_map_info *next = info->next;
        mmput(info->mm);
        kfree(info);
        return next;
 }
 
-static struct map_info *
-build_map_info(struct address_space *mapping, loff_t offset, bool is_register)
+static struct uprobe_map_info *
+uprobe_build_map_info(struct address_space *mapping, loff_t offset,
+                     bool is_register)
 {
        unsigned long pgoff = offset >> PAGE_SHIFT;
        struct vm_area_struct *vma;
-       struct map_info *curr = NULL;
-       struct map_info *prev = NULL;
-       struct map_info *info;
+       struct uprobe_map_info *curr = NULL;
+       struct uprobe_map_info *prev = NULL;
+       struct uprobe_map_info *info;
        int more = 0;
 
  again:
@@ -730,7 +732,7 @@ static inline struct map_info *free_map_info(struct 
map_info *info)
                         * Needs GFP_NOWAIT to avoid i_mmap_rwsem recursion 
through
                         * reclaim. This is optimistic, no harm done if it 
fails.
                         */
-                       prev = kmalloc(sizeof(struct map_info),
+                       prev = kmalloc(sizeof(struct uprobe_map_info),
                                        GFP_NOWAIT | __GFP_NOMEMALLOC | 
__GFP_NOWARN);
                        if (prev)
                                prev->next = NULL;
@@ -763,7 +765,7 @@ static inline struct map_info *free_map_info(struct 
map_info *info)
        }
 
        do {
-               info = kmalloc(sizeof(struct map_info), GFP_KERNEL);
+               info = kmalloc(sizeof(struct uprobe_map_info), GFP_KERNEL);
                if (!info) {
                        curr = ERR_PTR(-ENOMEM);
                        goto out;
@@ -786,11 +788,11 @@ static inline struct map_info *free_map_info(struct 
map_info *info)
 register_for_each_vma(struct uprobe *uprobe, struct uprobe_consumer *new)
 {
        bool is_register = !!new;
-       struct map_info *info;
+       struct uprobe_map_info *info;
        int err = 0;
 
        percpu_down_write(&dup_mmap_sem);
-       info = build_map_info(uprobe->inode->i_mapping,
+       info = uprobe_build_map_info(uprobe->inode->i_mapping,
                                        uprobe->offset, is_register);
        if (IS_ERR(info)) {
                err = PTR_ERR(info);
@@ -828,7 +830,7 @@ static inline struct map_info *free_map_info(struct 
map_info *info)
  unlock:
                up_write(&mm->mmap_sem);
  free:
-               info = free_map_info(info);
+               info = uprobe_free_map_info(info);
        }
  out:
        percpu_up_write(&dup_mmap_sem);
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to