On Sun, 03 Dec 2023 18:46:22 +0100, Krzysztof Kozlowski wrote: > Document preferred coding style for Devicetree sources (DTS and DTSI), > to bring consistency among all (sub)architectures and ease in reviews. > > Cc: Andrew Davis <[email protected]> > cc: Andrew Lunn <[email protected]> > Cc: AngeloGioacchino Del Regno <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Bjorn Andersson <[email protected]> > Cc: Chen-Yu Tsai <[email protected]> > Cc: Dmitry Baryshkov <[email protected]> > Cc: Jonathan Corbet <[email protected]> > Cc: Matthias Brugger <[email protected]> > Cc: Michal Simek <[email protected]> > Cc: Neil Armstrong <[email protected]> > Cc: Nishanth Menon <[email protected]> > Cc: Olof Johansson <[email protected]> > Cc: Rafał Miłecki <[email protected]> > Acked-by: Neil Armstrong <[email protected]> > Acked-by: Heiko Stuebner <[email protected]> > Reviewed-by: Laurent Pinchart <[email protected]> > Acked-by: Konrad Dybcio <[email protected]> > Reviewed-by: Geert Uytterhoeven <[email protected]> > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > --- > > Merging idea: Rob/DT bindings > > Changes in v4 > ============= > 1. Drop label at the top (Jon) > 2. Grammar fixes (Laurent, Dragan) > 3. "Unless a bus defines differently, unit addresses shall ..." (Rob) > 4. Use hex in example of dma-controller (Andrew) > 5. Example: soc@ -> soc@0 > 6. Reverse points 2 and 3 in "Indentation" (Andrew) > 7. Use full path to coding style doc (Conor) > > Changes in v3 > ============= > 1. should->shall (Angelo) > 2. Comments // -> /* (Angelo, Michal) > 3. Use imaginary example in "Order of Properties in Device Node" > (Angelo) > 4. Added paragraphs for three sections with justifications of chosen > style. > 5. Allow two style of ordering overrides in board DTS: alphabetically or > by order of DTSI (Rob). > 6. I did not incorporate feedback about, due to lack of consensus and my > disagreement: > a. SoM being DTS without DTSI in "Organizing DTSI and DTS" > > Changes in v2 > ============= > 1. Hopefully incorporate entire feedback from comments: > a. Fix \ { => / { (Rob) > b. Name: dts-coding-style (Rob) > c. Exceptions for ordering nodes by name for Renesas and pinctrl (Geert, > Konrad) > d. Ordering properties by common/vendor (Rob) > e. Array entries in <> (Rob) > > 2. New chapter: Organizing DTSI and DTS > > 3. Several grammar fixes (missing articles) > > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > .../devicetree/bindings/dts-coding-style.rst | 196 ++++++++++++++++++ > Documentation/devicetree/bindings/index.rst | 1 + > 2 files changed, 197 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dts-coding-style.rst >
I added the quotes as discussed and applied, thanks! Rob
