Thorsten Leemhuis, 2024-05-12T09:47:31+02:00: > On 10.05.24 20:34, Karel Balej wrote: > > Update the handling-regressions guide to recommend using "Closes:" tags > > rather than "Link:" when referencing fixed reports. The latter was used > > originally but now is only recommended when the given patch only fixes > > part of the issue, as described in submitting-patches. Briefly mention > > that and also note that regzbot currently doesn't make a distinction. > > > > Also fix a typo. > > > > Signed-off-by: Karel Balej <bal...@matfyz.cz> > > Many thx for this, much appreciated. Looks good! > > Acked-by: Thorsten Leemhuis <li...@leemhuis.info>
Thanks! > One quick note: > > > > > What's important when fixing regressions > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > @@ -112,10 +115,16 @@ remember to do what > > Documentation/process/submitting-patches.rst, > > :ref:`Documentation/process/5.Posting.rst <development_posting>`, and > > Documentation/process/stable-kernel-rules.rst already explain in more > > detail: > > > > - * Point to all places where the issue was reported using "Link:" tags:: > > + * Point to all places where the issue was reported using "Closes:" tags:: > > > > - Link: > > https://lore.kernel.org/r/30th.anniversary.rep...@klaava.helsinki.fi/ > > - Link: https://bugzilla.kernel.org/show_bug.cgi?id=1234567890 > > + Closes: > > https://lore.kernel.org/r/30th.anniversary.rep...@klaava.helsinki.fi/ > > + Closes: https://bugzilla.kernel.org/show_bug.cgi?id=1234567890 > > + > > + If you are only fixing part of the issue, you may use "Link:" instead as > > + described in the first document mentioned above. > > Not totally sure if... > > > Some maintainers may even > > + prefer it over "Closes:" entirely, although the latter is generally > > + recommended. > > ...this sentence really should be here, but whatever. I think I can see your point. I added it as it was something you mentioned before but looking now at that mail again, I think this is not really what you said. So I'm in favour of dropping it. If you give me a go-ahead, I will send v3 with this sentence dropped and your Ack added right back. Thanks, kind regards, K. B.
