On Tue, Apr 22, 2025 at 2:30 PM Mina Almasry <almasrym...@google.com> wrote: > > On Tue, Apr 22, 2025 at 10:43 AM Harshitha Ramamurthy > <hramamur...@google.com> wrote: > > > > On Thu, Apr 17, 2025 at 4:15 PM Mina Almasry <almasrym...@google.com> wrote: > > > > > > Use netmem_dma_*() helpers in gve_tx_dqo.c DQO-RDA paths to > > > enable netmem TX support in that mode. > > > > > > Declare support for netmem TX in GVE DQO-RDA mode. > > > > > > Signed-off-by: Mina Almasry <almasrym...@google.com> > > > > > > --- > > > > > > v4: > > > - New patch > > > --- > > > drivers/net/ethernet/google/gve/gve_main.c | 4 ++++ > > > drivers/net/ethernet/google/gve/gve_tx_dqo.c | 8 +++++--- > > > 2 files changed, 9 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/google/gve/gve_main.c > > > b/drivers/net/ethernet/google/gve/gve_main.c > > > index 8aaac9101377..430314225d4d 100644 > > > --- a/drivers/net/ethernet/google/gve/gve_main.c > > > +++ b/drivers/net/ethernet/google/gve/gve_main.c > > > @@ -2665,6 +2665,10 @@ static int gve_probe(struct pci_dev *pdev, const > > > struct pci_device_id *ent) > > > > > > dev_info(&pdev->dev, "GVE version %s\n", gve_version_str); > > > dev_info(&pdev->dev, "GVE queue format %d\n", > > > (int)priv->queue_format); > > > + > > > + if (!gve_is_gqi(priv) && !gve_is_qpl(priv)) > > > + dev->netmem_tx = true; > > > + > > > > a nit: but it would fit in better and be more uniform if this is set > > earlier in the function where other features are set for the > > net_device. > > > > Thanks for taking a look. I actually thought about that while trying > to implement this, but AFAIU (correct if wrong), gve_is_gqi and > gve_is_qpl need priv to be initialized, so this feature set must be > performed after gve_init_priv in this function. I suppose this feature > checking maybe can be put before register_netdev. Do you prefer that?
Ah yes, you are right. Thanks for checking. That would be preferable. Another option is to move it inside gve_init_priv() after the mode has been set. Either is okay. Thanks, Harshitha > > > -- > Thanks, > Mina
