Re: [PATCH v4 08/15] iommupt: Add read_and_clear_dirty op

[Randy Dunlap]

On 8/26/25 10:18 AM, Jason Gunthorpe wrote:
> +/**
> + * read_and_clear_dirty() - Manipulate the HW set write dirty state
> + * @iommu_table: Table to manipulate
> + * @iova: IO virtual address to start
> + * @size: Length of the IOVA
> + * @flags: A bitmap of IOMMU_DIRTY_NO_CLEAR
> + *

Mismatch between @params above and function arguments, both in names
and one argument (@dirty:) is missing above.

> + * Iterate over all the entries in the mapped range and record their write 
> dirty
> + * status in iommu_dirty_bitmap. If IOMMU_DIRTY_NO_CLEAR is not specified 
> then
> + * the entries will be left dirty, otherwise they are returned to being not
> + * write dirty.
> + *
> + * Context: The caller must hold a read range lock that includes @iova.
> + *
> + * Returns: -ERRNO on failure, 0 on success.
> + */
> +int DOMAIN_NS(read_and_clear_dirty)(struct iommu_domain *domain,
> +                                 unsigned long iova, size_t size,
> +                                 unsigned long flags,
> +                                 struct iommu_dirty_bitmap *dirty)
> +{


-- 
~Randy