Hi, Jakub:
On Tue, Sep 23, 2025 at 06:08:54PM -0700, Jakub Kicinski wrote:
> On Mon, 22 Sep 2025 09:41:07 +0800 Dong Yibo wrote:
> > +===========================================================
> > +Linux Base Driver for MUCSE(R) Gigabit PCI Express Adapters
> > +===========================================================
> > +
> > +MUCSE Gigabit Linux driver.
>
> You already said that in the heading above
>
> > +Copyright (c) 2020 - 2025 MUCSE Co.,Ltd.
>
> copyright is metadata, it should not be part of the user-visible doc.
>
> > +Identifying Your Adapter
> > +========================
> > +The driver is compatible with devices based on the following:
> > +
> > + * MUCSE(R) Ethernet Controller N500 series
> > + * MUCSE(R) Ethernet Controller N210 series
>
> These are out of numeric sort order
>
> > +Support
> > +=======
> > + If you have problems with the software or hardware, please contact our
> > + customer support team via email at [email protected] or check our
> > + website at https://www.mucse.com/en/
>
> Please don't add support statements. People can use a search engine if
> they want to find the corporate support. The kernel docs are for kernel
> topics, and "support" in the kernel is done on the mailing list.
>
>
Got it. I will update this file like this:
.. SPDX-License-Identifier: GPL-2.0
===========================================================
Linux Base Driver for MUCSE(R) Gigabit PCI Express Adapters
===========================================================
Identifying Your Adapter
========================
The driver is compatible with devices based on the following:
* MUCSE(R) Ethernet Controller N210 series
* MUCSE(R) Ethernet Controller N500 series
> > +config MGBE
> > + tristate "Mucse(R) 1GbE PCI Express adapters support"
> > + depends on PCI
> > + select PAGE_POOL
>
> you're not using page pool in this series
>
Yes, I will remove it, and add this when truely use.
> > +MODULE_DEVICE_TABLE(pci, rnpgbe_pci_tbl);
> > +MODULE_AUTHOR("Mucse Corporation, <[email protected]>");
>
> Only humans can author code, not corporations. Delete his AUTHOR entry
> or add yourself as the author.
>
Will fix this.
> > +MODULE_DESCRIPTION("Mucse(R) 1 Gigabit PCI Express Network Driver");
> > +MODULE_LICENSE("GPL");
>
>
Thanks for your feedback.
