On 12/2/25 19:04, Jakub Kicinski wrote:
On Sun, 30 Nov 2025 23:35:19 +0000 Pavel Begunkov wrote:+enum { + /* queue restart support custom rx buffer sizes */ + NDO_QUEUE_RX_BUF_SIZE = 0x1,If you have to respin -- let's drop the NDO from this define. To suggest something specific - QCFG_ is a better prefix? IDK why we ended up with ndo_ prefix on the queue ops..
QCFG_ sounds better indeed
Also RX_PAGE_SIZE is a better name for the fields? RX_BUF_SIZE is easy to confuse with RX_BUF_LEN which we are no longer trying to modify.
It's not "page" because there are no struct page's, and those are just buffers. Maybe it's also some net/driver specific term? I don't get the difference here b/w "size" and "len" either, but in any case I don't really have any real opinion about the name, and it can always be changed later. -- Pavel Begunkov
