--On Dienstag, 19. August 2003 12:45 +0200 Johannes Stezenbach <[EMAIL PROTECTED]> wrote:
Log unifying: av7110-logunified.c.diff ttpci_eeprom-logunified.c.diff ves1820-cvs20030816-to-logunified.c.diff
Add more often prefix "DVB: " to log lines, like already seen sometimes in current driver version.
Mho: good chance for commit to current version
Looks good, but there's a problem: I currently don't have time to port changes to DVB forward to dvb-kernel, which means if you want me to apply changes to DVB you (or someone else) will have to send me similar patches for dvb-kernel.
Can do this, against which sources? linux-2.6.0-test$latest? Or is there a extra cvs tree somewhere.
Add pwm option to module: ves1820-logunified-to-pwmoption.c.diff (note: CLKCONF and CARCONF support are removed because they are no longer needed)
Mho: not so big chance for commit to current version, Holger don't like module option, but perhaps more users can convince him to accept it ;-)
I would apply this, because I think it's useful, and I don't know if the EEPROM is writable at all (could be write-protected), and if it is writable you could shoot yourself in the foot by writing crap to it. Also there's no utility for writing the EPPROM.
But I need similar patch for dvb-kernel first.
Same issue.
Limit AFC logging to a limit of lines per card and per 'init chip' ves1820-pwmoption-AFCloglimit.c.diff
Mho: not very sure that this patch would be commited to current version, perhaps, if some users vote for it ;-)
I don't like this.
Like expected ;-)
IMHO the VES1820 driver should always printk the PWM value from EEPROM during initialization. AFC can be printed with Jaakko's utility. We just need a pointer to it and a "howto fix dvb-c tuning problems" doc.
Solution? Change all "dprintk" in ves1820.c to "printk" except the one of AFC logging? (can do this).
BTW: a one shot AFC log line would be still a good idea...not everyone reads a doc after running into trouble.
But what about this idea:
Do not log AFC data normally, but display a warning, if e.g. AFC is a little bit out-of-range (e.g. -4 to +4 is ok?) and a note about try to fix adjusting the PWM value?
I can implement this tonight, if requested.
Peter -- Dr. Peter Bieringer http://www.bieringer.de/pb/ GPG/PGP Key 0x958F422D mailto: pb at bieringer dot de Deep Space 6 Co-Founder and Core Member http://www.deepspace6.net/
-- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe linux-dvb" as subject.
