From: Jan Kiszka <jan.kis...@siemens.com>

If kmap or vmap fail, it means we ran out of memory. There are no
user-provided addressed involved that would justify EFAULT.

Signed-off-by: Jan Kiszka <jan.kis...@siemens.com>
Cc: Matt Fleming <m...@codeblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
---
 drivers/firmware/efi/capsule-loader.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/capsule-loader.c 
b/drivers/firmware/efi/capsule-loader.c
index 9ae6c116c474..91e91f7a8807 100644
--- a/drivers/firmware/efi/capsule-loader.c
+++ b/drivers/firmware/efi/capsule-loader.c
@@ -113,7 +113,7 @@ static ssize_t efi_capsule_submit_update(struct 
capsule_info *cap_info)
                        VM_MAP, PAGE_KERNEL);
        if (!cap_hdr_temp) {
                pr_debug("%s: vmap() failed\n", __func__);
-               return -EFAULT;
+               return -ENOMEM;
        }
 
        ret = efi_capsule_update(cap_hdr_temp, cap_info->pages);
@@ -185,7 +185,7 @@ static ssize_t efi_capsule_write(struct file *file, const 
char __user *buff,
        kbuff = kmap(page);
        if (!kbuff) {
                pr_debug("%s: kmap() failed\n", __func__);
-               ret = -EFAULT;
+               ret = -ENOMEM;
                goto failed;
        }
        kbuff += PAGE_SIZE - cap_info->page_bytes_remain;
-- 
2.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to