On Wed, Mar 26, 2025 at 10:59:52AM +0200, Andy Shevchenko wrote: > On Tue, Mar 25, 2025 at 05:33:03PM -0700, Nathan Chancellor wrote: > > #define _LINUX_NLS_H > > > > #include <linux/init.h> > > As I just replied to your previous mail, consider fixing this list as well > by adding module.h and types.h. > > ... > > Overall, can you browse the Ingo's series [1] for the stuff related to this, > if any? > > I would avoid doing double efforts or different approaches if we already have > something ready.
In Ingo's last fast-headers tree [1], nls.h only has export.h and init.h included, so it does not look like anything around this was changed from what I can tell. types.h is going to be included via the new nls_types.h and while it does definitely look like module.h should be included, I do not really have the time and build capacity at the moment to incorporate testing that change into this series. I will stick with these two changes for now then I, you, or someone else can revisit cleaning up nls.h later. [1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/tree/include/linux/nls.h?h=sched/headers Cheers, Nathan
