On Wed, Apr 30, 2025 at 09:19:38AM -0700, Josh Poimboeuf wrote: > On Wed, Apr 30, 2025 at 01:07:36PM +0200, Peter Zijlstra wrote: > > +++ b/arch/x86/kvm/emulate.c > > @@ -267,11 +267,56 @@ static void invalidate_registers(struct > > X86_EFLAGS_PF|X86_EFLAGS_CF) > > > > #ifdef CONFIG_X86_64 > > -#define ON64(x) x > > +#define ON64(x...) x > > #else > > #define ON64(x) > > Doesn't the 32-bit version need to be > > #define ON64(x...) > > since it now accepts multiple "args"?
Right, so far the robot hasn't complained, but yeah, consistency would demand this :-) > > -FASTOP1(not); > > -FASTOP1(neg); > > -FASTOP1(inc); > > -FASTOP1(dec); > > +COP1(not); > > +COP1(neg); > > +COP1(inc); > > +COP1(dec); > > I assume COP stands for "C op", but that will never be obvious. Aww :-) Right before sending I wondered if EM_ASM_*() would be a better namespace.
