Re: Subject: [PATCH 12/16] Squashfs: header files

[Phillip Lougher]

Geert Uytterhoeven wrote:
On Fri, 17 Oct 2008, Phillip Lougher wrote:

+#ifdef SQUASHFS_TRACE
+#define TRACE(s, args...)      printk(KERN_NOTICE "SQUASHFS: "s, ## args)
+#else
+#define TRACE(s, args...)      {}
+#endif

Just use

    #define TRACE(s, args...)   pr_debug("SQUASHFS: "s, ## args)

OK.

+
+#define WARNING(s, args...)    printk(KERN_WARNING "SQUASHFS: "s, ## args)
                                ^^^^^^^^^^^^^^^^
                                pr_warning(


OK.


SQUASHFS_MKFLAGS() isn't used by the kernel, only by the tools (mksquashfs)?


Only used by mksquashfs.  I pulled out the user-space only stuff into a 
separate include, but must have missed this one.

+/* meta index cache */
+#define SQUASHFS_META_INDEXES  (SQUASHFS_METADATA_SIZE / sizeof(unsigned int))
                                                                         
^^^^^^^^^^^^
I was wondering whether a meta index is an `unsigned int' or an `__le32', but I
couldn't find it easily.


Unsigned int, it's used internally by the index cache code (file.c).  It 
works out how many block indexes can fit into one compressed metadata block.

Phillip
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html