Hello Jaya,
On Sun, Jan 25, 2009 at 05:54:47PM +0800, Jaya Kumar wrote:
> - split the patches into generic, arch specific and am300epd
I would swap the order to have:
generic
am300epd
pxa specific
This way the tree of the second commit is a test case for the generic
implementation.
> - adjusting the API to remove width (note, the actual API call where
> width was dropped is in the arch specific code, not here.)
Nevertheless I would document the "generic" per arch specific
implementation in gpio.txt. For the functions like __gpio_get_value you
can just do
#define gpio_get_value(gpio) __gpio_get_value(gpio)
but for your batch functions you need something like
#define gpio_set_batch(startpin, mask, values) \
({ u32 __mask = mask; __gpio_set_batch(startpin, __mask,
fls(__mask), values);})
Maybe better use/recommend an inline function?
> Cc: David Brownell <[email protected]>
> Cc: Eric Miao <[email protected]>
> Cc: Paulius Zaleckas <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Jaya Kumar <[email protected]>
Note you didn't Cc: me.
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
