On 11/06/2010 09:58 PM, Marco Stornelli wrote:
> From: Marco Stornelli <[email protected]>
> 
> Definitions for the PRAMFS filesystem.
> 
> Signed-off-by: Marco Stornelli <[email protected]>
> ---
> diff -Nurp linux-2.6.36-orig/fs/pramfs/pram.h linux-2.6.36/fs/pramfs/pram.h
> --- linux-2.6.36-orig/fs/pramfs/pram.h        1970-01-01 01:00:00.000000000 
> +0100
> +++ linux-2.6.36/fs/pramfs/pram.h     2010-10-30 12:02:45.000000000 +0200
> @@ -0,0 +1,317 @@

> +/*
> + * Structure of the super block in PRAMFS
> + */
> +struct pram_super_block {
> +     __be16  s_sum;          /* checksum of this sb, including padding */
> +     __be64  s_size;         /* total size of fs in bytes */
> +     __be32  s_blocksize;    /* blocksize in bytes */
> +     __be32  s_inodes_count; /* total inodes count (used or free) */
> +     __be32  s_free_inodes_count;/* free inodes count */
> +     __be32  s_free_inode_hint;  /* start hint for locating free inodes */
> +     __be32  s_blocks_count; /* total data blocks count (used or free) */
> +     __be32  s_free_blocks_count;/* free data blocks count */
> +     __be32  s_free_blocknr_hint;/* free data blocks count */
> +     __be64  s_bitmap_start; /* data block in-use bitmap location */
> +     __be32  s_bitmap_blocks;/* size of bitmap in number of blocks */
> +     __be32  s_mtime;        /* Mount time */
> +     __be32  s_wtime;        /* Write time */
> +     __be16  s_magic;        /* Magic signature */
> +     char    s_volume_name[16]; /* volume name */
> +};

Is there a particular reason to use big endian types for the data
structures? On a little endian machine you will end up converting values
everywhere. I assume that you don't expect the machine to change
endianess between reboots :-). If this is for generating/reading
filesystems from userspace, wouldn't it be better to have the userspace
tools specify the target endianess and do the conversions there?

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon                     5 Amuri Park, 404 Barbadoes St
[email protected]           PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com     New Zealand
Phone: +64 3 3779127            Freecall: Australia 1800 148 751
Fax:   +64 3 3779135                      USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to