Mike:
Thanks for the great feedback and detailed going-over. Will fix all your points, but have a question: On Sun, Feb 20, 2011 at 4:46 PM, Mike Frysinger <[email protected]> wrote: >> +#ifdef MODULE >> +module_init(pwm_init); >> +module_exit(pwm_exit); >> +MODULE_LICENSE("GPL"); >> +#else >> +postcore_initcall(pwm_init); >> +#endif > > i dont think you need this MODULE trickery. common code already takes > care of this for you, and it'd let you avoid a warning about pwm_exit > being unused. So the postcore_initcall() becomes equivalent to module_init() when I build as a module? That would make sense, but I had never thought about it before now... b.g. -- Bill Gatliff [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
