Hi Haruue, On Fri, Nov 22, 2019 at 04:58:59PM +0800, Haruue Icymoon wrote: > ./configure will fail when --with-lz4-libdir is not set, since > $with_lz4_libdir will be an empty string and generate an empty -L > into LDFLAGS. This patch fixes it. > > Signed-off-by: Haruue Icymoon <[email protected]> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index f925358..870dfb9 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -174,7 +174,7 @@ if test "x$enable_lz4" = "xyes"; then > > if test "x${have_lz4h}" = "xyes" ; then > saved_LDFLAGS=${LDFLAGS} > - LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}" > + test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}" > AC_CHECK_LIB(lz4, LZ4_compress_destSize, [ > have_lz4="yes" > have_lz4hc="yes" > -- > 2.24.0
Thanks for your patch. *thumb* Applied to experimental branch now, and I will move it to dev branch tomorrow since it's a useful trivial build fix for some debian builds as well [1]. [1] https://buildd.debian.org/status/package.php?p=erofs-utils https://buildd.debian.org/status/fetch.php?pkg=erofs-utils&arch=hppa&ver=1.0-3&stamp=1573917897&raw=0 Thanks, Gao Xiang > > > -- > Haruue Icymoon > GPG: E16D 3FA4 E636 A602 2684 0D38 A54A 7E9C 812E EB09 > https://haruue.moe/ >
