From: Baokun Li <libaok...@huawei.com>

Pass the error code to ret when xlen < 0 to avoid misleading the caller.

Fixes: 72b957856b0c ("cachefiles: Implement metadata/coherency data storage in 
xattrs")
Signed-off-by: Baokun Li <libaok...@huawei.com>
---
 fs/cachefiles/xattr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/cachefiles/xattr.c b/fs/cachefiles/xattr.c
index 20e4a4391090..4dd8a993c60a 100644
--- a/fs/cachefiles/xattr.c
+++ b/fs/cachefiles/xattr.c
@@ -110,9 +110,11 @@ int cachefiles_check_auxdata(struct cachefiles_object 
*object, struct file *file
        if (xlen == 0)
                xlen = vfs_getxattr(&nop_mnt_idmap, dentry, 
cachefiles_xattr_cache, buf, tlen);
        if (xlen != tlen) {
-               if (xlen < 0)
+               if (xlen < 0) {
+                       ret = xlen;
                        trace_cachefiles_vfs_error(object, file_inode(file), 
xlen,
                                                   
cachefiles_trace_getxattr_error);
+               }
                if (xlen == -EIO)
                        cachefiles_io_error_obj(
                                object,
-- 
2.39.2

Reply via email to