Re: [PATCH v8 3/9] erofs: move `struct erofs_anon_fs_type` to super.c

[Gao Xiang]

On 2025/11/14 17:55, Hongbo Li wrote:

From: Hongzhen Luo <hongz...@linux.alibaba.com>

Move the `struct erofs_anon_fs_type` to the super.c and
expose it in preparation for the upcoming page cache share
feature.

Signed-off-by: Hongzhen Luo <hongz...@linux.alibaba.com>
Signed-off-by: Hongbo Li <lihongb...@huawei.com>
---
  fs/erofs/fscache.c  | 13 -------------
  fs/erofs/internal.h |  4 ++++
  fs/erofs/super.c    | 15 +++++++++++++++
  3 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 362acf828279..2d1683479fc0 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -3,7 +3,6 @@
   * Copyright (C) 2022, Alibaba Cloud
   * Copyright (C) 2022, Bytedance Inc. All rights reserved.
   */
-#include <linux/pseudo_fs.h>
  #include <linux/fscache.h>
  #include "internal.h"

@@ -13,18 +12,6 @@ static LIST_HEAD(erofs_domain_list);

  static LIST_HEAD(erofs_domain_cookies_list);
  static struct vfsmount *erofs_pseudo_mnt;

-static int erofs_anon_init_fs_context(struct fs_context *fc)

-{
-       return init_pseudo(fc, EROFS_SUPER_MAGIC) ? 0 : -ENOMEM;
-}
-
-static struct file_system_type erofs_anon_fs_type = {
-       .owner          = THIS_MODULE,
-       .name           = "pseudo_erofs",
-       .init_fs_context = erofs_anon_init_fs_context,
-       .kill_sb        = kill_anon_super,
-};
-
  struct erofs_fscache_io {
        struct netfs_cache_resources cres;
        struct iov_iter         iter;
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index f7f622836198..e80b35db18e4 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -188,6 +188,10 @@ static inline bool erofs_is_fileio_mode(struct 
erofs_sb_info *sbi)
        return IS_ENABLED(CONFIG_EROFS_FS_BACKED_BY_FILE) && sbi->dif0.file;
  }

+#if defined(CONFIG_EROFS_FS_ONDEMAND)

+extern struct file_system_type erofs_anon_fs_type;
+#endif

It's unnecessary to use #ifdef for "extern", otherwise
it looks good me.

Thanks,
Gao Xiang