Hi Xiang,
Could you please consider these two patches?
The first patch includes unit tests covering the modified parts,
while for the second patch, I added some simple smoke tests [1] to
prevent regressions.
As we previously discussed, I suggest handling the documentation updates
in a separate,
subsequent commit—since the entire `--oci=` (and also `--s3=`) argument
is currently
undocumented, not just the newly added `oci.insecure` option.
[1] https://github.com/erofs/erofsnightly/pull/2
Thanks,
Yifan Zhao
On 2025/12/2 18:41, Gao Xiang wrote:
On 2025/12/2 18:28, zhaoyifan (H) wrote:
On 2025/12/2 15:40, Gao Xiang wrote:
Hi Yifan,
Would you mind updating mkfs.erofs manpage too?
Thanks,
Gao Xiang
Hi Xiang,
Do you mean document `--oci` option in man/mkfs.erofs.1?
Seems there's no manual about `--oci` and `--s3` there? How about
adding them in a new patch later?
Yes, a seperate patch is absolutely fine.
Since it's about time to release erofs-utils 1.9, so it'd be
helpful to update outdated manpage.
Thanks,
Gao Xiang
Thanks,
Yifan
