Re: [PATCH v11 07/10] erofs: introduce the page cache share feature

[Gao Xiang]

On 2025/12/24 17:26, Hongbo Li wrote:

Hi, Xiang
On 2025/12/24 16:09, Gao Xiang wrote:

...

why return `struct erofs_inode_fingerprint` instead of:

int erofs_xattr_get_ishare_fp(struct erofs_inode_fingerprint *fp,
                   struct inode *inode, const char *domain_id)

instead?

How about declaring this as void erofs_xattr_fill_ishare_fp(struct 
erofs_inode_fingerprint *fp, struct inode *inode, const char *domain_id)? 
Because the return value seems useless.

I still perfer to return different values for this helper
even the final user doesn't use this.

Thanks,
Gao Xiang

Thanks,
Hongbo