On Thu 08-01-26 12:13:01, Jeff Layton wrote: > Add the setlease file_operation to ext4_file_operations and > ext4_dir_operations, pointing to generic_setlease. A future patch will > change the default behavior to reject lease attempts with -EINVAL when > there is no setlease file operation defined. Add generic_setlease to > retain the ability to set leases on this filesystem. > > Signed-off-by: Jeff Layton <[email protected]>
Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/ext4/dir.c | 2 ++ > fs/ext4/file.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c > index > 256fe2c1d4c1619eb2cd915d8b6b05bce72656e7..00c4b3c82b6534790962dc3964c0c557162b6dff > 100644 > --- a/fs/ext4/dir.c > +++ b/fs/ext4/dir.c > @@ -24,6 +24,7 @@ > > #include <linux/fs.h> > #include <linux/buffer_head.h> > +#include <linux/filelock.h> > #include <linux/slab.h> > #include <linux/iversion.h> > #include <linux/unicode.h> > @@ -690,4 +691,5 @@ const struct file_operations ext4_dir_operations = { > #endif > .fsync = ext4_sync_file, > .release = ext4_release_dir, > + .setlease = generic_setlease, > }; > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index > 7a8b3093218921f26a7f8962f94739ba49431230..534cf864101f8d1e5f4106b61c0580c858bc0e27 > 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -25,6 +25,7 @@ > #include <linux/mount.h> > #include <linux/path.h> > #include <linux/dax.h> > +#include <linux/filelock.h> > #include <linux/quotaops.h> > #include <linux/pagevec.h> > #include <linux/uio.h> > @@ -980,6 +981,7 @@ const struct file_operations ext4_file_operations = { > .fop_flags = FOP_MMAP_SYNC | FOP_BUFFER_RASYNC | > FOP_DIO_PARALLEL_WRITE | > FOP_DONTCACHE, > + .setlease = generic_setlease, > }; > > const struct inode_operations ext4_file_inode_operations = { > > -- > 2.52.0 > -- Jan Kara <[email protected]> SUSE Labs, CR
