On Thu 08-01-26 12:13:15, Jeff Layton wrote: > Add the setlease file_operation pointing to generic_setlease to the udf > file_operations structures. A future patch will change the default > behavior to reject lease attempts with -EINVAL when there is no > setlease file operation defined. Add generic_setlease to retain the > ability to set leases on this filesystem. > > Signed-off-by: Jeff Layton <[email protected]>
Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/udf/dir.c | 2 ++ > fs/udf/file.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/fs/udf/dir.c b/fs/udf/dir.c > index > 5023dfe191e8088b78396997a8915bf383f7a2d2..5bf75638f3520ecb3a0a2ade2279ab56787ecd11 > 100644 > --- a/fs/udf/dir.c > +++ b/fs/udf/dir.c > @@ -24,6 +24,7 @@ > > #include <linux/string.h> > #include <linux/errno.h> > +#include <linux/filelock.h> > #include <linux/mm.h> > #include <linux/slab.h> > #include <linux/bio.h> > @@ -157,4 +158,5 @@ const struct file_operations udf_dir_operations = { > .iterate_shared = udf_readdir, > .unlocked_ioctl = udf_ioctl, > .fsync = generic_file_fsync, > + .setlease = generic_setlease, > }; > diff --git a/fs/udf/file.c b/fs/udf/file.c > index > 0d76c4f37b3e71ffe6a883a8d97a6c3038d2a01d..32ae7cfd72c549958b70824b449cf146f6750f44 > 100644 > --- a/fs/udf/file.c > +++ b/fs/udf/file.c > @@ -28,6 +28,7 @@ > #include <linux/string.h> /* memset */ > #include <linux/capability.h> > #include <linux/errno.h> > +#include <linux/filelock.h> > #include <linux/pagemap.h> > #include <linux/uio.h> > > @@ -208,6 +209,7 @@ const struct file_operations udf_file_operations = { > .splice_read = filemap_splice_read, > .splice_write = iter_file_splice_write, > .llseek = generic_file_llseek, > + .setlease = generic_setlease, > }; > > static int udf_setattr(struct mnt_idmap *idmap, struct dentry *dentry, > > -- > 2.52.0 > -- Jan Kara <[email protected]> SUSE Labs, CR
